fix(python): uniyfing redis connection args for Queue and Worker #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
approved these changes
Nov 29, 2023
roggervalf
force-pushed
the
python-unify-redis-args
branch
from
3c845e2
to
6ceb8f6
Compare
roggervalf
changed the base branch from
master
to
feat/better-handling-of-queue-markers
roggervalf
merged commit 8eee20f
into
taskforcesh:feat/better-handling-of-queue-markers
10 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
# [5.0.0](v4.17.0...v5.0.0) (2023-12-21) ### Bug Fixes * **connection:** require connection to be passed ([#2335](#2335)) ([1867dd1](1867dd1)) * **job:** revert console warn custom job ids when they represent integers ([#2312](#2312)) ([84015ff](84015ff)) * **python:** unify redis connection args for Queue and Worker ([#2282](#2282)) ([8eee20f](8eee20f)) * **worker:** throw error if connection is missing ([6491a18](6491a18)) ### Features * **job:** provide skipAttempt option when manually moving a job ([#2203](#2203)) ([0e88e4f](0e88e4f)) * **python:** use new queue markers ([b0a13e8](b0a13e8)) * **python:** use new queue markers ([4276eb7](4276eb7)) * **worker:** improved markers handling ([73cf5fc](73cf5fc)) * **worker:** improved markers handling ([0bac0fb](0bac0fb)) ### BREAKING CHANGES * **worker:** Markers use now a dedicated key in redis instead of using a special Job ID. * **worker:** Markers use now a dedicated key in redis instead of using a special Job ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the NodeJS version has the same connection arguments for the worker and queue whereas python as two different format.
It's a breaking change but using the same format might prevent bugs in the future