fix(repeat-strategy): add missing Promise return type #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eden-lane
reviewed
Nov 27, 2023
tests/test_repeat.ts
Outdated
| @@ -574,7 +574,7 @@ describe('repeat', function () { | |||
| } | |||
|
|
|||
| const next_occurrence = rrule.after(currentDate, false); | |||
| return next_occurrence?.getTime(); | |||
| return next_occurrence!.getTime()!; | |||
There was a problem hiding this comment.
Is this supposed to be a non-null assertion? rrule.after can return null and I thought that undefined is a valid value - it means that there are no next occurrence.
There was a problem hiding this comment.
thank you @eden-lane I could validate that getNextMillis function is returning undefined in some cases so this should be a valid case, I updated the typing in this case as well
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
## [4.14.4](v4.14.3...v4.14.4) (2023-11-28) ### Bug Fixes * **repeat-strategy:** add missing Promise return type ([#2301](#2301)) ([6f8f534](6f8f534))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2300