Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job ID is not preventing duplicates? #458

Closed
jorgecuesta opened this issue Apr 8, 2021 · 7 comments
Closed

Job ID is not preventing duplicates? #458

jorgecuesta opened this issue Apr 8, 2021 · 7 comments

Comments

@jorgecuesta
Copy link

jorgecuesta commented Apr 8, 2021

HI People I'm new using BullMQ is my first time with this, is an awesome tool and is working amazing.
My case is a long story but basically I'm generating the job id based on another id of an element that I need to process.
Today using Bull Dashboard I figure out that is I run queue.addBulk with an id that is already added it adds a duplicate.
Screenshot_2021-04-08_12-41-57
Here you can see that everything in the job is the same, but the added time is different and the # are both different
#22769 Added at 12:17:37 vs #34939 Added at 12:33:48

So my question is, am I doing something wrong? I maybe miss something important enought that get my jobs repeated?

@manast
Copy link
Contributor

manast commented Apr 8, 2021

Interesting, it seems like jobId is indeed ignored, since I see different ids on the left, #34939 vs #22769. Will take a look at this.

@manast
Copy link
Contributor

manast commented Apr 8, 2021

ok, I found the issue, I will submit a patch soon.

@jorgecuesta
Copy link
Author

ok @manast please let me know when you be able to fix it. Thanks!

@manast
Copy link
Contributor

manast commented Apr 10, 2021

I was working on this PR so I fixed it here: #454
will be released today.

@jorgecuesta
Copy link
Author

jorgecuesta commented Apr 12, 2021

@manast pr is merge but I see that latest release is 24 days ago, when you plan release this?

@manast
Copy link
Contributor

manast commented Apr 12, 2021

not yet sorry. There is an error with the deployment that I need to fix first.

@manast
Copy link
Contributor

manast commented Apr 12, 2021

It is released now.

@manast manast closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants