Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow task removed doesn't remove data relative #504

Closed
koiszzz opened this issue Apr 27, 2021 · 6 comments · Fixed by #559
Closed

Flow task removed doesn't remove data relative #504

koiszzz opened this issue Apr 27, 2021 · 6 comments · Fixed by #559
Labels
bug Something isn't working released

Comments

@koiszzz
Copy link

koiszzz commented Apr 27, 2021

const worker1 = new Worker('test1', async job => {
       return 1;
});
const worker2 = new Worker('test2', async job => {
       return 2;
});
const flowPro = new FlowProducer();

(async() => {
    await flowPro.add({
            name: 'parent-task', data: {}, queueName: 'test1', opts: {removeOnComplete: true},
            children: [{name: 'children-task', data: {}, queueName: 'test2', opts: {removeOnComplete: true}}]
    });
})();

After running these codes, the redis still remain some data that named pid:processed and pid:event.

@manast
Copy link
Contributor

manast commented Apr 27, 2021

not sure if it was a typo in your exampel code but you wrote: removeIOnComplete instead of removeOnComplete. Let me know if still does not work and I will take a look into it.

@koiszzz
Copy link
Author

koiszzz commented Apr 28, 2021

Please ignore that I have spelled wrongly when I post this issue. In my code , it was spelled correctly. The parent job and child job were removed after running this code, but there still remains a hash type data named parent-job-id:process and a stream type data named parent-job-id:events. @manast
Image of remained data

@manast manast added the bug Something isn't working label Apr 28, 2021
@roggervalf
Copy link
Collaborator

@manast one doubt, the parent events stream should also be removed?

@manast
Copy link
Contributor

manast commented May 20, 2021

the events are for the queue not for the job so they should not be removed.

@manast
Copy link
Contributor

manast commented May 20, 2021

but why are there event streams for "jobs", I think there is a bug that is making the events end in the wrong key actually.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.26.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants