Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocha types are not included as part of bullmqs dependencies (But are needed?) #894

Closed
zkldi opened this issue Nov 26, 2021 · 2 comments · Fixed by #895
Closed

Mocha types are not included as part of bullmqs dependencies (But are needed?) #894

zkldi opened this issue Nov 26, 2021 · 2 comments · Fixed by #895

Comments

@zkldi
Copy link

zkldi commented Nov 26, 2021

Relevant error:

node_modules/.pnpm/bullmq@1.54.4/node_modules/bullmq/dist/utils.d.ts:2:23 - error TS2688: Cannot find type definition file for 'mocha'.

2 /// <reference types="mocha" />

Looks like @types/mocha isnt a dependency of bullmq but code won't compile unless you have those types set. Should @types/mocha be part of the dependencies?

@manast
Copy link
Contributor

manast commented Nov 26, 2021

Thanks for reporting this, will take a look asap.

@zkldi
Copy link
Author

zkldi commented Nov 26, 2021

Thanks for such a fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants