proper handling of error when err object null, but status is not 200

elasticsearch-dump · Dec 14, 2018 · 5ace347 · 5ace347
1 parent dea4160
commit 5ace347
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/lib/transports/elasticsearch.js b/lib/transports/elasticsearch.js
@@ -593,7 +593,14 @@ class elasticsearch {
 
     aws4signer(payload, this.parent)
     this.baseRequest(payload, (err, response) => {
-      if (err) { return callback(err) }
+      if (err) {
+        callback(err, [])
+        return
+      } else if (response.statusCode !== 200) {
+        err = new Error(response.body)
+        callback(err, [])
+        return
+      }
 
       try {
         const r = jsonParser.parse(response.body, this.parent)