Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/refactoring v2 #4

Merged
merged 2 commits into from Sep 18, 2022
Merged

Feat/refactoring v2 #4

merged 2 commits into from Sep 18, 2022

Conversation

tatanpoker09
Copy link
Owner

Problema

Descripción del problema a resolver.

Solución

Lista con soluciones implementadas.

  • feature 1
  • feature 2
  • docs
  • style decision
  • known bugs introduced
  • useful commands
  • etc...

Resuelve

Palabras claves para resolver issues automáticamente como resolves #<issue-number>

Esta pull request resolves #1

@gitguardian
Copy link

gitguardian bot commented Sep 18, 2022

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4457932 Google Cloud Keys 0eb0a3c channels/journey_speech/google-application-credentials.json View secret
4457932 Google Cloud Keys 0eb0a3c journey_central/google-application-credentials.json View secret
4484677 Telegram Bot Token 3890422 channels/JourneyTelegramBot/main.py View secret
4484678 Telegram Bot Token 3890422 integrations/TelegramSenderIntegration/main.py View secret
4457932 Google Cloud Keys 3890422 journey_central/google-application-credentials.json View secret
2501487 Google API Key 3890422 journey_central/scripts/play_song.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@tatanpoker09 tatanpoker09 merged commit 5a6d7b8 into main Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant