Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with InverseCrosstile3D #188

Closed
jzwar opened this issue Jul 5, 2023 · 2 comments · Fixed by #211
Closed

Issue with InverseCrosstile3D #188

jzwar opened this issue Jul 5, 2023 · 2 comments · Fixed by #211
Assignees
@jzwar
Labels
bug Something isn't working

Comments

@jzwar
Copy link
Collaborator

jzwar commented Jul 5, 2023

The edge cases seem to be redundant and result in tangled splines. I don't know where they came from but we might need to check their consistency!

Concerns all splines 12-end in the create_tile-function
@jzwar jzwar added the bug Something isn't working label Jul 5, 2023
@jzwar jzwar self-assigned this Jul 5, 2023
@j042
Copy link
Member

j042 commented Jul 5, 2023

If this is a new issue since 0.0.26, maybe you can check whether cartesian_product is used correctly. That's something I changed during the migration

@jzwar
Copy link
Collaborator Author

jzwar commented Jul 6, 2023

No, I think there is a definition problem. I will need to look into that once I am back in the Institute.

@jzwar jzwar mentioned this issue Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzwar jzwar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Crosstile and Inverse tataratat/splinepy
2 participants
@j042 @jzwar