Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags translation problem: tags are displayed in English or Romaji, not Simplified Chinese. #193

Closed
shikiroot opened this issue Jan 6, 2022 · 5 comments
Closed

Tags translation problem: tags are displayed in English or Romaji, not Simplified Chinese. #193

shikiroot opened this issue Jan 6, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@shikiroot
Copy link

OS: iPadOS 15.2
System Language: English
App Language: Simplified Chinese
When I use the app, tags are displayed in English or Romaji, not Simplified Chinese.

Expected

IMG_0022

Actual

IMG_0020
@tatsuz0u
Copy link
Contributor

tatsuz0u commented Jan 6, 2022 •
edited

Tags will and should be English unless you turn on the Translates tags feature which you can find in Setting - General. EhPanda will hide the Translates tags switch if it failed to download the translation database. In that case maybe you should fix your network first.

@tatsuz0u tatsuz0u closed this as completed Jan 6, 2022
@tatsuz0u tatsuz0u added the invalid This doesn't seem right label Jan 6, 2022
@tatsuz0u tatsuz0u mentioned this issue Jan 11, 2022
Closed
@leng-yue
Copy link
Contributor

I found the bug: the version number of the simplified Chinese database was updated to 6. And this will case a parseFailed error here: https://github.com/tatsuz0u/EhPanda/blob/3c919cbfdf313d171c5e7586c46e8db724a748ad/EhPanda/Network/Request.swift#L107

@tatsuz0u tatsuz0u reopened this Jan 11, 2022
@tatsuz0u tatsuz0u removed the invalid This doesn't seem right label Jan 11, 2022
@leng-yue
Copy link
Contributor

Simply change the version number can fix this bug: #196

@tatsuz0u
Copy link
Contributor

tatsuz0u commented Jan 11, 2022 •
edited

I'm terribly sorry!!! I'll look into it after work.

@tatsuz0u
Copy link
Contributor

Fixed in #196 by @leng-yue.

@tatsuz0u tatsuz0u added the bug Something isn't working label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leng-yue @tatsuz0u @shikiroot