Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] "Enter fullscreen" doesn't change display name while in fullscreen #391

Closed
kotx opened this issue May 8, 2022 · 2 comments · Fixed by #390
Closed

[bug] "Enter fullscreen" doesn't change display name while in fullscreen #391

kotx opened this issue May 8, 2022 · 2 comments · Fixed by #390

Comments

@kotx
Copy link

kotx commented May 8, 2022

Describe the bug

This is fine:
image

But after I enter fullscreen:
image

Reproduction

let view_menu = Menu::new().add_native_item(MenuItem::EnterFullScreen);
let menu = Menu::new().add_submenu(view_menu);
tauri::Builder::default().menu(menu)
// ...

Expected behavior

Menu item changes to "Exit fullscreen". Alternatively we can have the menu item just show "Fullscreen", optionally with a checkbox to show the state, like VSCode:
image

Platform and versions

Environment
  › OS: Mac OS 12.3.1 X64
  › Node.js: 16.14.2
  › npm: 8.5.0
  › pnpm: 6.11.0
  › yarn: 1.22.15
  › rustup: 1.24.3
  › rustc: 1.60.0
  › cargo: 1.60.0
  › Rust toolchain: stable-aarch64-apple-darwin 

Packages
  › @tauri-apps/cli [NPM]: 1.0.0-rc.10
  › @tauri-apps/api [NPM]: 1.0.0-rc.5
  › tauri [RUST]: 1.0.0-rc.9,
  › tauri-build [RUST]: 1.0.0-rc.8,
  › tao [RUST]: 0.8.4,
  › wry [RUST]: 0.16.0,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:3000/

App directory structure
  ├─ dist
  ├─ node_modules
  ├─ src-tauri
  └─ src

Stack trace

No response

Additional context

No response

@kotx kotx added the type: bug label May 8, 2022
@keiya01
Copy link
Member

keiya01 commented May 12, 2022

I think this issue is related to https://github.com/tauri-apps/tao. But to redraw title we need to change current process.
As the easy way, we can also change default title in the following code. hmm..

"Enter Full Screen",

@lucasfernog lucasfernog transferred this issue from tauri-apps/tauri May 15, 2022
@wusyong
Copy link
Member

wusyong commented May 17, 2022

Maybe we can rename to "Toggle Full Screen" just for easy fix.

keiya01 added a commit to keiya01/tao that referenced this issue May 17, 2022
keiya01 added a commit to keiya01/tao that referenced this issue May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants