Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite/Improve Events guide #1152

Open
FabianLars opened this issue Mar 8, 2023 · 1 comment
Open

Rewrite/Improve Events guide #1152

FabianLars opened this issue Mar 8, 2023 · 1 comment
Labels
enhancement Does it add or improve content? good first issue Is it good for beginners to take up?
Milestone

Comments

@FabianLars
Copy link
Member

Also related: #486.

If possible we should look into improving it before the new docs are there. The guide causes too much confusion.

I will try to expand this list every time i see people having issues related to the guide or events.

  • It emits events in the setup hook without some kind of condition. (New) users will therefore often encounter timing issues (emitting events before the js side starts to listen to them)
  • Usage of unlisten() right after listening to it - idk if it's caused by mindless copy-paste but this was a problem in peoples apps wayyy too often.
  • no mention of the need to unlisten in js when something like component unmounting happens.
  • no docs on rust to rust communication -> talking about the trigger methods
@FabianLars FabianLars added documentation good first issue Is it good for beginners to take up? labels Mar 8, 2023
@simonhyll
Copy link
Sponsor Contributor

Tracking for 2.0, think we're a bit too close to 2.0 for it to be worth fixing in 1.0. Will definitely need to keep these things in mind when writing a guide on events!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content? good first issue Is it good for beginners to take up?
Projects
Status: 💪 Ready
Development

No branches or pull requests

3 participants