Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WSS support #8

Closed
oberstet opened this issue Feb 17, 2012 · 41 comments
Closed

add WSS support #8

oberstet opened this issue Feb 17, 2012 · 41 comments

Comments

@oberstet
Copy link
Contributor

No description provided.

@oberstet
Copy link
Contributor Author

"""
The "problem" with adding WSS support to Autobahn is as follows.

First, if you use classic, blocking netwoork code (which also does
involve copying things around) like i.e. Weberknecht, adding SSL
is totally easy:

http://code.google.com/p/weberknecht/source/browse/trunk/src/main/de/roderick/weberknecht/WebSocketConnection.java#247

Now, Autobahn uses Java NIO .. for performance reasons, since it
doesn't copy things around.

Unforntunately, there doesn't seem to be an easy analog to

SocketChannel

like i.e. SSLSocketChannel.

When you Google for "Java NIO SSL" .. it seems to be non-trivial, sadly.

What's needed with Autobahn and WSS is extending the code here:

https://github.com/oberstet/AutobahnAndroid/blob/master/Autobahn/src/de/tavendo/autobahn/WebSocketConnection.java#L76
"""

@sublimator
Copy link

@oberstet

I'm working on a proof of concept prototype app using Autobahn at the moment. I can't get wss:// to work atm, so will just use ws://, however, for production a secure transport will be a necessity.

Is wss:// very high on your priority? If all goes to plan and I could dedicate some time to working on wss:// would you imagine having the time/inclination to provide guidance?

Thanks.

@oberstet
Copy link
Contributor Author

oberstet commented Oct 9, 2012

Unfort., I have currently no time to work on WSS .. there is a "nearly working" TLS-NIO version here: https://github.com/tavendo/AutobahnAndroid/tree/tlsnio
There are bugs left .. best would take that branch as starting point fixing the bugs. Also see the discussion here (which explains how we arrived at that branch):
#14

@sublimator
Copy link

Thanks for reply :) I'll get back if/when I look into it.

ps. Autobahn seems great thus far :)

@danieltwagner
Copy link

Have you been able to make any progress on wss? I'm evaluating different WebSocket libraries for Android and AutobahnAndroid is looking very good so far, but not being able to use WSS is a deal breaker. I might be able to contribute if there is a list of known bugs for the tlsnio branch?

@sublimator
Copy link

We just went ahead and used AutoBahn for our prototype and feel comfortable
that we can deal with wss when we need it. Autobahn is a solid project and
you'll find many others use their test suite.

Not sure exactly when we'll be focusing on wss, but it's on the cards as
we'll need it one day.

@danieltwagner
Copy link

I might consider doing this but will need to switch to WSS rather soon as we found that some mobile operators interfere with non-TLS connections, inadvertently breaking WebSocket connections.

@sublimator
Copy link

Will let you know when we can contribute. Will try and get boss to give it
some priority but at this point it's just not hugely important for us.

@danieltwagner
Copy link

Cool, thanks for being super responsive! :)

@sublimator
Copy link

Just FYI, in case you missed it, I'm not really involved in the project,
just a consumer :)

@danieltwagner
Copy link

Yeah, I got that. Still good to know that someone else is out there!

@sublimator
Copy link

Likewise :)

@danieloskarsson
Copy link

@darenschwenke
Copy link

"I might consider doing this but will need to switch to WSS rather soon as we found that some mobile operators interfere with non-TLS connections, inadvertently breaking WebSocket connections."

Yep. Seems to be common.

@ocroquette
Copy link

Just a note to say it would be really great to have TLS support in Autobahn Android!

@sublimator
Copy link

Yep :) !

@brunettia
Copy link

So at the moment, what's the best option for using wss on android ? Does it works in Autobahn ? 'Cause I really like this library!! :)

@tommyvn
Copy link

tommyvn commented Jul 5, 2013

oberstet did mention that there may be bugs on the TLS branch for your wss needs but so far it has been good to me. What we've used it for isn't in production tho.....

@brunettia
Copy link

alright thank you very much, i'll try it!

@danieloskarsson
Copy link

I don't know if it's the best option, but we do use SecureWebSockets which I linked to above in our production code, sending quite a big number of messages.

@ocroquette
Copy link

For my app, I switched for this reason to https://github.com/koush/android-websockets
SSL is working fine.

@epicblood
Copy link

Any update on if/when this will be implemented?
Would really hate to have to switch my libs.

@oberstet
Copy link
Contributor Author

Sorry, I am overloaded with stuff. This will be implemented, definitely. I cannot promise you a deadline, but I will take up dev on AutobahnAndroid again soon - WAMPv2 needs to be implemened as well.

@sublimator
Copy link

There is also: https://github.com/TooTallNate/Java-WebSocket

@mandrachek
Copy link

Since the NIO issue has supposedly been resolved on Android >= 3.0, will this work out of the box on API levels >= 14? I haven't had much luck with the other implementations mentioned on this thread. :(

@akhiljayaram
Copy link

@oberstet please add wss support.. Autobahn was super perfect for ws.. But for wss , using TLS branch, connection goes sometimes.

@prasad-1210
Copy link

+1 for wss support from autobahn. I've been watching this space since last 1 year for WSS ):

@xsren
Copy link

xsren commented May 27, 2015

+1 for wss support from autobahn.

1 similar comment
@ilber
Copy link

ilber commented Sep 3, 2015

+1 for wss support from autobahn.

@LoveWalter
Copy link

+1 for wss support from autobahn..

1 similar comment
@zeuscode
Copy link

+1 for wss support from autobahn..

@rsclmumbai
Copy link

+1 for wss support from autobahn.

@rsclmumbai
Copy link

BTW, is there any work around to have a secure data exchange?

@szczepaan
Copy link

is this topic alive ?

@goeddea
Copy link
Contributor

goeddea commented Apr 6, 2016

We have found somebody who will do an update of Autobahn|Android (which will include support for WAMP v2). No definite timeline yet (best guess at the moment: Q3).

@oberstet
Copy link
Contributor Author

this will be addressed as part of #92

@szczepaan
Copy link

Any status update on that timeline?

@RabbitPie
Copy link

+1 for wss support from autobahn.

@atonamy
Copy link

atonamy commented Nov 7, 2016

Hey today November 2016 and still no any official support for wss :(
I like this library but it's useless for production because ssl is very important for commercial app.
We tried to use this implementation https://github.com/palmerc/SecureWebSockets but is memory leak issue in the code :(

There only one stable option for Android now so far is https://github.com/TooTallNate/Java-WebSocket which is support ssl. The rest solutions is useless because lack of full wss support for websockets.

Why like this? Why we don't have strong secure layer support in websocket libraries for Android? Websocket is not popular for professional developers? Or anyone don't care about sensitivity of their data in apps and use ws in production?

@erobic
Copy link

erobic commented Mar 15, 2017

@atonamy Neovisionaries web socket client: https://github.com/TakahikoKawasaki/nv-websocket-client also supports wss.

@atonamy
Copy link

atonamy commented Mar 20, 2017

@erobic
Thanks a lot for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests