Improve WebSocket subprotocol error handling #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebSocket client would reject server responses that specified a subprotocol that wasn't on the client's subprotocol list. This is fine, except for the case when the client's subprotocol list is empty. In that case, the client should accept any server selected subprotocol, provided that the header does not appear more than once.
|
No, I don't think this behavior would be valid: "If the response includes a |Sec-WebSocket-Protocol| header field |
opticron
pushed a commit
to opticron/asterisk-testsuite-temporary
that referenced
this pull request
Oct 6, 2014
With AuthBahn WebSocket client, we must specify the subprotocol that the server specifies. See crossbario/autobahn-python#147 git-svn-id: file:///home/opticron/private_mirror/testsuite_secondary/asterisk/trunk@3925 ad95026d-47f8-4470-b445-30a6b62014f3
leedm777
added a commit
to asterisk/testsuite
that referenced
this pull request
Mar 25, 2015
With AuthBahn WebSocket client, we must specify the subprotocol that the server specifies. See crossbario/autobahn-python#147 git-svn-id: https://origsvn.digium.com/svn/testsuite/asterisk/trunk@3925 a5964663-950a-4945-9369-5dd0b5cb08c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebSocket client would reject server responses that specified a
subprotocol that wasn't on the client's subprotocol list. This is fine,
except for the case when the client's subprotocol list is empty.
In that case, the client should accept any server selected subprotocol,
provided that the header does not appear more than once.