Description

I've tried to implement a little something that hopefully increases the reliability of the power state reading, as I personally too experienced the random "on" states in HomeKit, although the device was actually off (see #676, #663, #608, ). What I did is I've added power state reading over the SmartThings API.

Power State over SmartThings API

A code block for reading the state of the device over the SmartThings API was added. The code integrates with the existing logic inside the getPower() method of the remote.js. Should an error happen it is gracefully caught and the default pinging and HTTP local API flow is executed. I've tried to make it as less as invasive as possible and went against adding it inside base.js, as to avoid possible circular references. Also, the smart things logic is kept separate from the other ones, so the remotes.js felt like the best fit.

Under the SmartThings API section I've added the opt-in feature to use SmartThings API for power state readings to turn it on.

Furthermore, an API call is sent out once every 5 seconds. This seems to be quite fine for the endpoint's rate limiter (350 requests per minute allowed). The endpoint for the GET request is under https://api.smartthings.com/v1/devices/:deviceId/components/main/capabilities/switch/status. This information is also found under the general status endpoint (https://api.smartthings.com/v1/devices/:deviceId/status), but I've narrowed it down a bit. The response looks like so:

{
  "switch": {
    "value": "on", // either "on" or "off"
    "timestamp": "2024-04-27T20:43:46.563Z"
  }
}

Quality of Life Improvements

I've fixed few spelling errors and extended/improved the javascript documentation above some of the methods. Generally I tried to keep the same coding style as established in the project. Also, the additional debug logging you'll see I've added for myself to understand the inner workings better. I'd leave it up to you to decide if you'd like to keep it or not. I personally see no harm in keeping it.

Final thoughts

I do really like the approach you've taken first pinging the device's IP and then only if you it's reachable, you call the local device API (port 8001). Could not really understand why the random "on" state would appear in HomeKit, although it happened to me too, but never reproduced it successfully. I hope at least this change would help resolve the issues above.

• resolves Question - Device Power State Triggers  #676
• resolves Tv is off but the homekit app says it's on #663
• resolves Power Status Unexpectedly Changes #608