Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for bash without exported symbols #23

Open
taviso opened this issue Aug 7, 2015 · 4 comments
Open

support for bash without exported symbols #23

taviso opened this issue Aug 7, 2015 · 4 comments
Milestone

Comments

@taviso
Copy link
Owner

taviso commented Aug 7, 2015

It may be possible to support incorrectly built bash binaries that are very stable (for example, Apple's).
We could hash the binary, and if it matches a binary we know about it use a pre-generated symbol.map.

Is it worth all the extra complexity to support OS X? On the one hand, this is an Apple bug that they should fix (they built bash incorrectly, a feature that is supposed to work doesn't) - on the other hand, it seems unlikely they'll fix a bug in such an obscure feature for at least a few years.

@cemeyer
Copy link
Collaborator

cemeyer commented Aug 7, 2015

Hm, where would you get such a symbol.map for it? Or do Apple ship debug symbols you could generate such a thing with?

@taviso
Copy link
Owner Author

taviso commented Aug 7, 2015

Yes, I think using debug symbols will work, will just have to create a bunch of pointers to the symbols we need. It's a bit ugly, and I don't know if many Mac users are interested in this...

@cemeyer
Copy link
Collaborator

cemeyer commented Aug 7, 2015

That's cute. I'm for it. Seems to be much in the spirit of ctypes.sh ;).

I wonder if instead of changing the code too much, we could just add a bash-compat.c shim that only weakly provides the bash exported symbols and looks them up and proxies the calls if actually invoked?

@taviso
Copy link
Owner Author

taviso commented Aug 7, 2015

OK, let's try to get support for OS X in the first release (or at least investigate the possibility...) :)

block #17

@taviso taviso added this to the 1.0-RELEASE milestone Aug 7, 2015
@taviso taviso modified the milestones: FUTURE, 1.0-RELEASE Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants