Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read express port from environment #36

Open
tawn33y opened this issue Sep 8, 2022 · 2 comments
Open

Read express port from environment #36

tawn33y opened this issue Sep 8, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@tawn33y
Copy link
Owner

tawn33y commented Sep 8, 2022

From #19

Add functionality to read the server port from process.env

Suggested change from #19:

// startExpressServer.js line 100

// change
const port = options?.port || 3000;

// to
const port = options?.port || process.env.PORT || 3000;
@tawn33y tawn33y added the good first issue Good for newcomers label Oct 25, 2022
@TEMHITHORPHE
Copy link

This looks trivial to support, can I do this??

@tawn33y
Copy link
Owner Author

tawn33y commented Jul 17, 2023

Definitely! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants