Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with the 'countries' gem #6

Closed
WKD opened this issue Sep 8, 2016 · 2 comments
Closed

Conflict with the 'countries' gem #6

WKD opened this issue Sep 8, 2016 · 2 comments

Comments

@WKD
Copy link

WKD commented Sep 8, 2016

Since the Taxamo classes doesn't use namespaces, it can easily conflict with classes from other gems and/or Rails applications, especially on models using common names (such as Country & Report).

This happens with the "countries" gem (used by country_select and simple_form) :
https://github.com/hexorx/countries

When you try to use both Taxamo and this gem, you get a loading error.

My opinion is that every class in Taxamo should be prefixed by a Taxamo namespace.

@tlipski
Copy link
Contributor

tlipski commented Sep 8, 2016

Hi @WKD

Please try '2.0.1' version from 2.0 brach:

https://github.com/taxamo/taxamo-ruby/tree/2.0

@WKD
Copy link
Author

WKD commented Sep 20, 2016

Hello,

It indeed worked very well, thanks!

Maybe you should advertise this release on rubygems.org?

@WKD WKD closed this as completed Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants