Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with IgnoreFrom #28

Closed
SimeonC opened this issue Jun 9, 2014 · 3 comments · Fixed by #27
Closed

Issue with IgnoreFrom #28

SimeonC opened this issue Jun 9, 2014 · 3 comments · Fixed by #27

Comments

@SimeonC
Copy link

SimeonC commented Jun 9, 2014

Hey there. Really cool work here!

I've been trying to use this as a method to drag bootstrap modals by their header, but any buttons I put in are not being ignored. Example here: http://codepen.io/SimeonC/pen/qzCto

Issue is that when I click and drag on a button (either cancel or send) I expected the ignoreFrom: 'button' part to stop the modal being dragged around (prevent dragging). As it is you can still drag the modal by clicking on either of the buttons.

Have I done something wrong?

@taye
Copy link
Owner

taye commented Jun 9, 2014

Thanks

This is my fault. I neglected to test the ignoreFrom setting with non selector Interactables. I'll try to fix it a few hours from now.

The good news is that if you use interact('#handle') instead of passing the element, your example seems to work fine.

@taye
Copy link
Owner

taye commented Jun 9, 2014

ignoreFrom should work correctly if you use this version: https://raw.githubusercontent.com/taye/interact.js/better-settings/interact.js

I'll merge the changes into master soon if no other bugs come up.

@SimeonC
Copy link
Author

SimeonC commented Jun 10, 2014

That works thanks, I've tested it in my codepen and updated it.
Thanks for the quick response!!

@taye taye closed this as completed in #27 Jun 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants