Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gesture onend event occasionally does not fire #52

Closed
jdewit opened this issue Jul 29, 2014 · 4 comments · Fixed by #53
Closed

gesture onend event occasionally does not fire #52

jdewit opened this issue Jul 29, 2014 · 4 comments · Fixed by #53

Comments

@jdewit
Copy link
Contributor

jdewit commented Jul 29, 2014

checkout fiddle and pinch/zoom on the items a few times. Eventually you will notice that the onend event does not log its output.

When this happens, it prevents other interactions from happening as well. It seems like its stuck.

Tested on ipad3 on safari.
@taye
Copy link
Owner

taye commented Jul 29, 2014

Thanks for reporting. It might take me some time to look into this as I'll have to borrow an iThing to test on.

@taye taye mentioned this issue Jul 30, 2014
Merged
@taye
Copy link
Owner

taye commented Jul 30, 2014

I found the problem and have a fix for it. Could you confirm that the problem no longer exists using https://rawgit.com/taye/interact.js/bugfix-ios-gestureend/interact.js?

@jdewit
Copy link
Contributor Author

jdewit commented Jul 31, 2014

You fixed it. Thanks for getting to this so quickly!

@jdewit jdewit closed this as completed Jul 31, 2014
@taye
Copy link
Owner

taye commented Aug 1, 2014

I need to update the tests so that they are less broken so I haven't merged the fix into master yet. Hopefully I'll get this done very soon.

@taye taye reopened this Aug 1, 2014
@taye taye closed this as completed in #53 Aug 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a problem where gesture actions sometimes don't end correctly on iOS taye/interact.js
2 participants
@jdewit @taye