Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Resizable with modifier aspectRatio #963

Merged
merged 1 commit into from Jun 11, 2022
Merged

Bug Resizable with modifier aspectRatio #963

merged 1 commit into from Jun 11, 2022

Conversation

tups
Copy link
Contributor

@tups tups commented Apr 8, 2022

Sorry, PR #945 closed due to bad push force ^^

Here is the new PR with the updated "main" branch.

The last message:
Fixed the bug when creating a resizable element with a "modifier": "aspectRatio". The top right and bottom left angle works in reverse.

Here is an example: https://codepen.io/tups/pen/RwLgmLO

Fixed issue : #944

@taye
Copy link
Owner

taye commented Jun 11, 2022

Can you reword your commit to fix(modifiers/aspectRatio): ...? Then I'll merge after I write some tests

@taye taye merged commit df5f871 into taye:main Jun 11, 2022
@taye
Copy link
Owner

taye commented Jun 11, 2022

Realized I can squash with a different commit message. Thanks again for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants