Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to work with currency #2

Closed
taylodl opened this issue Feb 7, 2024 · 1 comment
Closed

Need to work with currency #2

taylodl opened this issue Feb 7, 2024 · 1 comment
Assignees

Comments

@taylodl
Copy link
Owner

taylodl commented Feb 7, 2024

Basic implementation works, but currency handling isn't quite where it should be

The monthly payment, monthly principle, and monthly interest should all be in currency = not floats. The numbers should add as expected. The client won't like numbers that don't add, not even for a POC.

@taylodl taylodl self-assigned this Feb 7, 2024
@taylodl
Copy link
Owner Author

taylodl commented Feb 7, 2024

That was a PITA, but it's done. Haven't really had to worry about currency before. Gotta get the numbers right and make sure everything adds up!

Also fixed a minor mistake in making the monthly payment calculation. Weird - for some loans it was right, for others it was wrong. I forced the order of precedence to make sure the calculation was right and that fixed things.

@taylodl taylodl closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant