Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brca_annotate_maf doesn't work as expected #2

Closed
jyu2012 opened this issue Apr 22, 2019 · 0 comments · Fixed by #8
Closed

brca_annotate_maf doesn't work as expected #2

jyu2012 opened this issue Apr 22, 2019 · 0 comments · Fixed by #8

Comments

@jyu2012
Copy link

jyu2012 commented Apr 22, 2019

query_brca_exchange works as expected and returned three additional fields, however, brca_annotate_maf returned all 3 fields with NA values. guess the parsing function of annot field returned from query_brca_exchange does not work properly.

also query_brca_exchange checked start position, end, ref and alt. It seems too stringent as i can see a few insertion/deletion variants had annotation missing. The reason is the standard to set start and end for insertion or deletion is not well established. It might be better to check either start or end, plus ref and alt. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant