Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console is undefined #25

Closed
ngentile opened this issue Apr 22, 2016 · 2 comments
Closed

console is undefined #25

ngentile opened this issue Apr 22, 2016 · 2 comments

Comments

@ngentile
Copy link

ngentile commented Apr 22, 2016

Hi @taylorhakes, I think it would be good if we can evaluate if console is defined before fire the console.warm in order to avoid 'console is undefined' in browser like IE8. Yes is OLD! but in same cases we need to give support.

  var onUnhandledRejection = function onUnhandledRejection(err) {
    console.warn('Possible Unhandled Promise Rejection:', err); // eslint-disable-line no-console
  };

Thank you!! you made a great work!

@taylorhakes
Copy link
Owner

That is a great idea. Do you want to submit a pull request? Otherwise I can do it later today.

@taylorhakes
Copy link
Owner

I just submitted a fix. 1e62013 . If you see any issue, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants