Add preview, build, and playbook scripts #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihostage
approved these changes
Oct 26, 2022
| @@ -40,5 +52,5 @@ function faviconsTags(htmlWebpackPlugin) { | |||
| .filter((tag) => tag.tagName !== 'script') | |||
| .join('') | |||
| // It must be Handlebars template with root path as variable | |||
| .replaceAll('uiRootPath', '{{{uiRootPath}}}') | |||
| .replace(/uiRootPath/g, '{{{uiRootPath}}}') | |||
| @@ -5,10 +5,19 @@ const ZipPlugin = require('zip-webpack-plugin'); | |||
| const FaviconsPlugin = require('favicons-webpack-plugin') | |||
| const CopyPlugin = require('copy-webpack-plugin') | |||
| const HtmlPlugin = require('html-webpack-plugin') | |||
| const { CleanWebpackPlugin } = require('clean-webpack-plugin') | |||
There was a problem hiding this comment.
Why don't using a style that uses a few lines above? 🤔
I think CleanPlugin is more good name.
| @@ -5,10 +5,19 @@ const ZipPlugin = require('zip-webpack-plugin'); | |||
| const FaviconsPlugin = require('favicons-webpack-plugin') | |||
| const CopyPlugin = require('copy-webpack-plugin') | |||
| const HtmlPlugin = require('html-webpack-plugin') | |||
| const { CleanWebpackPlugin } = require('clean-webpack-plugin') | |||
| const path = require('path'); | |||
There was a problem hiding this comment.
Should we merge this line with line 3 that already has a require('path')?
| @@ -1,4846 +1,8 @@ | |||
| { | |||
| "name": "taymyr-antora-ui", | |||
| "version": "1.0.0", | |||
| "lockfileVersion": 2, | |||
| "lockfileVersion": 1, | |||
There was a problem hiding this comment.
Why we downgrade a lockfile version? 🤔
| "scripts": { | ||
| "preview": "npm-run-all -s build playbook", | ||
| "playbook": "antora antora-playbook.yml", | ||
| "build": "webpack" |
There was a problem hiding this comment.
I think that bundle is more semantic name and known to those who using Antora Default UI.
Suggested change
| "build": "webpack" | |
| "bundle": "webpack" |
| @@ -7,16 +7,24 @@ | |||
| "type": "git", | |||
| "url": "https://github.com/taymyr/taymyr-antora-ui.git" | |||
| }, | |||
| "scripts": { | |||
| "preview": "npm-run-all -s build playbook", | |||
| "playbook": "antora antora-playbook.yml", | |||
There was a problem hiding this comment.
I think antora or site are more suitable. playbook doesn't mean anything 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4