Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature Request - Statistics with Xiao Correction #12

Closed
Maithy15 opened this issue Apr 8, 2022 · 1 comment
Closed

New Feature Request - Statistics with Xiao Correction #12

Maithy15 opened this issue Apr 8, 2022 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@Maithy15
Copy link

Maithy15 commented Apr 8, 2022

Hi Sebastian,

Is it possible to implement another significant cutoff other than the ones available? It is called Xiao correction. Here is the link to the paper.
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC3957066/

Thanks
Maithy

@Maithy15 Maithy15 changed the title New Feature Request - Statistics with Xia Correction New Feature Request - Statistics with Xiao Correction Apr 8, 2022
@tbaccata tbaccata self-assigned this Apr 8, 2022
@tbaccata tbaccata added the question Further information is requested label Apr 8, 2022
@tbaccata
Copy link
Owner

tbaccata commented Apr 8, 2022

Hi Maithy,

with the global parameters in the Differential abundance tab you can already account for log2FC and (adj.) p-value thresholds.
A combined signficance cutoff (e.g -log10(p-value) * log2FC) is reasonable, when applied to a rank a list of genes for gene set enrichment analysis (GSEA), where you would usually consider all genes (DE or not DE).

amica's query interface was designed to provide user defined thresholds to retrieve a list of diff. abundant proteins, and then to apply subsequent analysis (e.g over-representation analysis) and visualizations on that list.
I don't see any improvement in a combined significance value for amica's functionality (for example, I'd have a more difficult time defining common, reasonable combined score cutoffs compared to the common filtering by significance and log2FC), I think the implemented thresholds are sufficient.

Best,
Sebastian

@tbaccata tbaccata closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants