Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer: Home phone field is breaking up families incorrectly #691

Closed
tbar0970 opened this issue Jan 14, 2021 · 1 comment
Closed

Importer: Home phone field is breaking up families incorrectly #691

tbar0970 opened this issue Jan 14, 2021 · 1 comment

Comments

@tbar0970
Copy link
Owner

If i import a CSV
John Jones - home phone 9741 1234
Sally Jones - home phone 9741 1234
it will put John and Sally in SEPARATE families which is wrong.
It's because the _isNewFamily function is stripping non-digits from the new value but comparing it to the previous row which doens't have non-digits stripped
//if ($field == 'home_tel') $newVal = preg_replace('/[^0-9]/', '', $newVal);

It needs to strip non-digits from both for comparison

@tbar0970
Copy link
Owner Author

Fixed in 92315d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant