Editing a staff account results in loss of custom fields

[jefft]

There looks to be a nasty bug in 2.32.0+ (not present in 2.31.2) that results in data loss. If a Person has an associated staff account, and you edit that staff account (e.g. to adjust their permissions, or mark them active/inactive), then all that person's custom fields are lost.

To replicate:

1. Add a custom field if none exists yet. E.g. here I've got a 'MultiCF' field:

2. On a Persons page for someone with an associated staff account, set the custom field. E.g. here the value is 'bar':

3. In Admin -> User Accounts, find the account and 'edit' it. This is the first sign of a problem: the custom field doesn't show, whereas previously (in 2.31.x) it did:

4. Fill in your 'current password' and click 'Update Account'.

5. View the Person record. You'll note the custom field is gone. The History shows it has been blanked out:

[jefft]

As for the bug cause: I reckon it's the missing custom fields on the edit_user_account form. Jethro 2.31 showed all custom fields. In 2.32 only a handpicked 5 show. Perhaps, when submitted, the edit_user_account code sees "hm, no custom fields. Blank them all!"

The change may have originated in c7301ca where the $fields variable changed from containing all fields, to containing just 5.

[tbar0970]

THanks for reporting. Leaving custom fields out of that form was a deliberate change (it all got too long).