Adds the ability to initialize the player with Data #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbaranes
reviewed
May 2, 2017
|
|
||
| do { | ||
| _ = try AudioPlayer(data: data) | ||
| XCTAssertTrue(false) |
There was a problem hiding this comment.
Ya, I was just trying to follow the pattern already established in the other tests:
Happy to switch it to XCTFail
|
Looks good. Just left a small preference about the tests. Can you also add an entry in the changelog? |
|
Closing due to inactivity, don't hesitate to reopen it if you are still interesting in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVAudioPlayerprovides a data initialization. So in a similar vein to the other AudioPlayer initializers, this provides a wrapper aroundAVAudioPlayer's data initializer.This is useful when dealing with audio from sources like
FileWrapperwhich only allows access toDatanot aURL.