Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error on swift 4 #24

Closed
marlon-sousa opened this issue Jan 28, 2018 · 2 comments
Closed

Compile error on swift 4 #24

marlon-sousa opened this issue Jan 28, 2018 · 2 comments

Comments

@marlon-sousa
Copy link

Hello,

I have used successfully this library but had to make a small change in order to compile it for swift v 4.

I am using xcode 9,1 here and the default configurations for a swift project.

On compiling, xcode complained that the HandleFadeTo function (line 86 currently) was not able to get seen by objective c and asked to include an @objc directive before it.

I did exactly that and then the compile went smoothly.

I wanted to submit a pool request but git specially on github is still confusing enough that I would not risk playing with branches on a public project, not yet at least. But here it is if you want to patch it yourself or for other people who happen to have the same issue.

@tbaranes
Copy link
Owner

tbaranes commented Jan 30, 2018

Thanks for the report! Swift 4 is already supported since last August, but I just saw that the CocoaPods version is outdated. So, I suppose you are installing the library using that dependency manager?

I will upload the last version to CocoaPods this week, thanks again for reporting this!

@tbaranes
Copy link
Owner

Finally made the CocoaPods release! I don't know why but the 1.6.0 was failing, but duplicating it and releasing a 1.6.1 (no diff) passed. Anyway, sorry for the delay, starting now AudioPlayerSwift is fully supporting Swift 4 using CocoaPods!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants