Cleaning array #51
Closed
Cleaning array #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In a second PR, I'd like to move a few methods in a |
tbaranes
force-pushed
the
feature/cleaning_array
branch
from
989eb1a
to
c3d9c0c
Compare
|
Okay, I'll have a look at them tomorrow, going to sleep now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning a bit the code for
ArrayExtension, and removing a few methods. I don't think that methods are really useful beside the safegetwhich has been replaced by the safe subscript.@Sweeper777 Can you take a look at this when you will have a few time? Let me know if you think we should keep some of them or remove / renames the others.