Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review request for Split #73

Closed
GoogleCodeExporter opened this issue Mar 23, 2015 · 2 comments
Closed

Code review request for Split #73

GoogleCodeExporter opened this issue Mar 23, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

Purpose of code changes on this branch:

When I added the Batch operator, I thought I could implement it in terms 
of a generalized Split operator. I was wrong, but the damage was already 
done and I had implemented and factored out all the work to implement a 
Split operator for any enumerable source. However, I have doubts about its 
general usefulness and is the reason why I am putting it in a branch.

When reviewing my code changes, please focus on:

I would appreciate it if you could review and comment on "utility" and 
general application of this operator. If you find that it makes good sense 
then I can merge it back into the turnk. Otherwise the branch can just 
serve as an archive.

Post your review to the following clone:
http://code.google.com/r/azizatif-morelinq-split/source/list

After review, I'll merge the clone with main.

Original issue reported on code.google.com by azizatif on 25 May 2012 at 4:40

@GoogleCodeExporter
Copy link
Author

Issue 8 has been merged into this issue.

Original comment by azizatif on 25 May 2012 at 4:41

@GoogleCodeExporter
Copy link
Author

This issue was closed by revision 79a03c125475.

Original comment by azizatif on 3 Jun 2012 at 7:48

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant