-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Following symlinks is a questionable default #61
Comments
Oh, nasty. Thank you for raising this. I'm of the mind to change symlinks to default nofollow, and expose the option with a flag. I don't have much experience with multiple filesystems, I don't see an immediate issue with allowing crossing filesystem boundaries if they're within the directories you've specified. This could be a flag too! I've been planning out a refactor, so these will get some attention. |
Thanks for a quick reply! For precedent, The filesystem thing is more niche, to be sure, especially if you're not following links. |
I agree that kondo dhouldn't follow symlinks by default or at least have an option to disable such behavior, or have an option to exclude certain directories from searching. Same situation as issue opener, scanned my proton prefixes. |
Thanks for raising this issue! I've disabled symlink following by default, you'll now be able to opt-in via a CLI flag. |
I tried
kondo
in my home directory, and it ended up scanning everything due to a symlink:It was taking a really long time, so I ran
strace
and found that it was lost somewhere in.../z:/proc
. I know there are symlink loops inprocfs
, and I thinkwalkdir
is supposed to detect loops, so maybe it would have figured that out eventually. Still, I don't think it's a good default to follow links, and other tools I know likefd-find
anddua-cli
do not.Semi-related, you might also want an option for
same_file_system
, but that's less clear as a default.The text was updated successfully, but these errors were encountered: