New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise progress formatting to space-leading three digit percentages #249

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
2 participants
@rivy
Contributor

rivy commented Nov 2, 2018

Formatting was a bit off for progress when hitting 100%. I thought the leading zeros were also distracting. I can put those back in if you prefer them. It's just not what I'm used to seeing.

before

C:>rm -r build .xmake & xmake
checking for the architecture ... x64
checking for the Microsoft Visual Studio (x64) version ... 2015
building to: build\windows.release.cl.x64\bin\hello.exe
[00%]: compiling.release src\main.rc
[50%]: compiling.release src\main.c
[100%]: linking.release hello.exe

after

C:>rm -r build .xmake & xmake
checking for the architecture ... x64
checking for the Microsoft Visual Studio (x64) version ... 2015
building to: build\windows.release.cl.x64\bin\hello.exe
[  0%]: compiling.release src\main.rc
[ 50%]: compiling.release src\main.c
[100%]: linking.release hello.exe

There was no single location for the change, so I changed it throughout the code base. I thought about localizing it to a single code location, but I wasn't sure where it would be best placed. Future localization would probably be a good idea though in order to plan for alternative formatting (different color choices, etc).

@waruqi waruqi changed the base branch from master to dev Nov 3, 2018

@waruqi waruqi merged commit 046f525 into tboox:dev Nov 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@waruqi

This comment has been minimized.

Member

waruqi commented Nov 3, 2018

Ok, thanks and I will move to a single code location in these days.

@rivy rivy deleted the rivy:rev.formatting branch Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment