Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The middleware overrides 'Set-Cookie' header #16

Closed
bakurin opened this issue Jan 21, 2020 · 1 comment
Closed

The middleware overrides 'Set-Cookie' header #16

bakurin opened this issue Jan 21, 2020 · 1 comment

Comments

@bakurin
Copy link
Contributor

bakurin commented Jan 21, 2020

The method LocalizationMiddleware::__invoke() uses MessageInterface::withHeader() method and overrides the http headers set before. Probably MessageInterface::withAddedHeader() should be considered to use instead?
@bakurin bakurin mentioned this issue Jan 21, 2020
Merged
@tboronczyk
Copy link
Owner

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tboronczyk @bakurin