Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPE & maven config updating #16

Closed
branflake2267 opened this issue Jun 3, 2014 · 4 comments
Closed

GPE & maven config updating #16

branflake2267 opened this issue Jun 3, 2014 · 4 comments

Comments

@branflake2267
Copy link

Just a quick question, I haven't had to time to confirm yet, but I wanted to ask when using maven m2e with eclipse and your plugin here if the the maven update is clicked on and run from eclipse, does the GPE properly update the GWT run config from your plugin maven configurations attributes?

@branflake2267
Copy link
Author

Just curious if you're pushing forward on this and if I should ask for tighter IDE integration?

@tbroyer
Copy link
Owner

tbroyer commented Oct 3, 2014

I honestly have no idea what to do with Maven plugins. The more I read the CodeHaus plugin's code the more I think we should rewrite it from scratch; but this plugin's approach might not be the best either. I quite like what Buck does (on a suggestion by @skybrian; see facebook/buck#109), but there might be an impedance mismatch with Maven's way of working (on the other hand, that'd be not really different from what surefire/failsafe or even the maven-compiler-plugin are doing). See also https://jira.codehaus.org/browse/MGWT-349#comment-353085 and #13

Note that I'm only talking here about the goals to compile and run the project, not the ones that generate gwt.xml files, or the way of bundling a mainModule manifest into JARs.

So, re. IDE integration, I'd wait a bit.

@branflake2267
Copy link
Author

Sounds good, thanks for the update.

@branflake2267
Copy link
Author

Just a note your plugin should integrate just fine sine the artifact names are the same and thats what the GPE and GWT Plugin fork are using. I can see your plugin has an advantage over the other maven plugin b/c it includes the lifecycle mapping. This is a annoying if someone puts the module the resources directory...

@tbroyer tbroyer closed this as completed Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants