-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevMode, gwt-lib
dependency and re-compiling changes
#31
Comments
Yes, sources from other projects in the reactor build are only added to the classpath by Leaving this issue open as a reminder that the documentation needs improvement. |
Great, thanks for clarifying. Along these lines:
Not sure if this is a separate issue. |
Yes it's a separate issue (likely a bug, probably due to changes in Maven in recent versions). |
Fixed by 69ac0f3 |
Sorry to spam this issue (isn't really a separate issue) but in case somebody ran into the same issue: IntelliJ won't import dependencies if they are using with the |
If we call it a problem then it's still present. I figured out that the NPE happens i.e. if you mess up the dependencies in your pom.xml with two entries for the same dependency (one with type gwt-lib and the second without any classifier). The plugin version I used for that is 1.0.0, GWT version 2.9.0, maven 3.6.3. ...just wanted to give my two cents here if someone comes by with the same problem. |
I am not sure if this is a bug or by design:
I created a reactor project for a GWT library which contains 2 modules:
gwt-lib
) itselfgwt-app
) as a showcase.Initially the sample gwt app had a simple dependency to the library (no classifier and no type declared). However when I run
mvn gwt:devmode
from my reactor project, changes to the library code (gwt-lib
) are not picked up (re-compiled). Only changes to the sample app are re-compiled.The debug output shows the following line:
If I add a second dependency to the library with a classifier of type
sources
or with a type ofgwt-lib
changes to the library will be properly re-compiled.I looked into the documentation and the only thing regarding this, was here:
https://tbroyer.github.io/gwt-maven-plugin/artifact-handlers.html
I also looked into the integration tests and only found the type of the dependency to be set to
gwt-lib
here:gwt-maven-plugin/src/it/e2e/e2e-client/pom.xml
Line 20 in 2877b61
This is with JDK 1.8.0_45, Maven 3.2.1 and gwt-maven-plugin 1.0-rc-2
The text was updated successfully, but these errors were encountered: