-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gwt:add-super-sources will not copy the sources to classpath #51
Comments
Looks like a MavenResourcesExecution needs to be invoked in the execute path. |
I copied MavenResourcesExecution from import sources into add super sources mojo execution path, and it worked. Is this something you can fix or would you like me to try to add a PR for it tomorrow? |
FYI, the only reason |
Gotcha. I was expecting to run the goal by itself and have it move the resources too. I think it would add some flexibility to the plugin. While I understand the ideal behavior would be not to add the resources twice on some paths of execution I don't see why it wouldn't be a problem to do it all in the goal too. This makes it troublesome to find a good execution path for m2e. I haven't found any workable path yet which means I have to look at other options if I can get anything to work with this plugin. |
What's the actual problem with m2e? What does it do (and when) that makes it incompatible with this behavior? Why do you need/want super sources copied to |
After you mentioned it should be copied in the resources phases got me to thinking it might be getting wiped so I'm trying to determine if I've got a race condition with another plugin. M2e in eclipse will add goals to the lifecycles to run. So I need to add the super sources into the classes, so I add the goal gwt:add-super-sources into the pom, which I see m2e picks up. I know it executes it, although since its only adding the resources to the maven project. From what it looks like it's either running after the resources execution, or it's a completely different config its adding the reference to the resources to. The module is generating at the same time, and I see it get added to the classes. All I really want is the super source get copied to the classes and I'll I want to do is add the goal to the plugin and have m2e pick that up and run it which it's doing it. But that goal I found like you said, is depending on resources:resources running another plugin. This I don't know how works yet, at least I don't know how and when m2e is running resources. |
I've been trying to avoid setting up the resource definition with the directory src/main/super, which fixes it. I've tried to avoid that b/c it adds the source folder to the ide, and then errors start to show up, but I forget, that resources are excluded by default. Ugh, so many layers I forget about. |
Running mvn gwt:add-super-sources to the classpath. Where mvn package will copy it. I'm trying to figure out how to debug the mojo, so I'm not sure what's going on yet. What'd I'd really like to happen is trigger it on some other phase, but I can't do that b/c it won't run by it self.
The text was updated successfully, but these errors were encountered: