-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<configuration> is missing a <skip> element for the codeserver goal #90
Comments
I don't understand your usecase (why would one use superdevmode rather than e.g. compiling in draft mode? when and how would the superdevmode server be stopped? etc.), but I believe the solution you're proposing is wrong. (to begin with, Could you share more details about what you're trying to do? |
The specific setup I have is thus: In a perfect world, I would run I have also received errors for the server component (for obvious reasons, attempts to find a GWT module fail) and the war module (no java source, and no module) when attempting to make this compile. To permit the normal workflow, I set up the pom for project-client to check for a property, and conditionally run the codeserver goal in the packaging phase. This permits both a normal compilation (by not setting the property) and a codeserver run which can find dependencies and does not error out on other submodules. Unfortunately, the way I had to do this was by making the property default to |
I suspect that your
In #86 I wondered if I shouldn't change the log level from DEBUG to INFO. What do you think? |
For a one-line message/module I think it's definitely worth lifting up the log level. |
Having tried And yes, I think that seeing the error at INFO (or even higher) would be helpful. |
If one wanted to optionally run a codeserver (with a command line switch), perhaps for development purposes, on build, there is no way to do it except for specifying it as gwt:codeserver. However, for projects with multiple Maven modules, this results in the gwt:codeserver goal being run against every Maven module. This leads to an error and an exit because the root project is frequently empty, and not all Maven modules necessarily produce GWT modules. The gwt:codeserver goal cannot be run directly against the submodules because the multimodule 'reactor' dependency resolution mechanism fails when Maven is attempting to compile a single Maven submodule.
To solve this, I suggest a
<skip>
option is added to the<configuration>
tag of the<execution>
tag for the codeserver goal.This will allow root (parent) pom.xml files to establish a property for controlling the codeserver's launch, which can them be set from the command line or through build profiles.
If you would like an example project which requires this addition to launch the codeserver, I can provide one.
The text was updated successfully, but these errors were encountered: