Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Renderer components aren't receiving shaders from bundles #6

Closed
hedgehog1029 opened this issue Sep 15, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working Custom backgrounds This issue affects charts with custom backgrounds MacOS This issue affects MacOS
Milestone

Comments

@hedgehog1029
Copy link
Member

The Mac shader loader currently only applies loaded shaders to Renderer components:

foreach (var renderer in bg.GetComponentsInChildren<Renderer>(true))

However, other components such as TextMeshProGUI and Graphic are not being queried here.

@hedgehog1029 hedgehog1029 added bug Something isn't working MacOS This issue affects MacOS Custom backgrounds This issue affects charts with custom backgrounds labels Sep 15, 2023
@hedgehog1029 hedgehog1029 added this to the v2.2.0 milestone Sep 16, 2023
@hedgehog1029 hedgehog1029 self-assigned this Sep 29, 2023
@hedgehog1029
Copy link
Member Author

There's a remaining issue with the text underlay shader not working, but I'm going to delay that fix to a point release as it'll require some debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Custom backgrounds This issue affects charts with custom backgrounds MacOS This issue affects MacOS
Projects
Status: Done
Development

No branches or pull requests

1 participant