Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change iterator end sentinel in IteratorStep from false to a spec enum #2551

Open
michaelficarra opened this issue Oct 13, 2021 · 0 comments
Open

change iterator end sentinel in IteratorStep from false to a spec enum #2551

michaelficarra opened this issue Oct 13, 2021 · 0 comments
Labels
editorial change good first issue

Comments

@michaelficarra
Copy link
Member

This AO currently returns an Object (typically an IteratorResult object, but I don't believe it's guaranteed) or false. It's weird to use false here. We should use a spec enum here like ~done~ or something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial change good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelficarra