Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in step 7 of the SuspendThisAgent abstract operation #3328

Open
declval opened this issue May 15, 2024 · 1 comment
Open

Typo in step 7 of the SuspendThisAgent abstract operation #3328

declval opened this issue May 15, 2024 · 1 comment
Labels

Comments

@declval
Copy link

declval commented May 15, 2024

At the end of step 7 of the SuspendThisAgent abstract operation the second argument to NotifyWaiter should be a waiterRecord (a Waiter Record) and not thisAgent (an agent signifier) according to the definition of NotifyWaiter.

The last sentence of step 7 reads:

The surrounding agent can only wake from suspension due to a timeout or due to another agent calling NotifyWaiter with arguments WL and thisAgent (i.e. via a call to Atomics.notify).

The first sentence of NotifyWaiter says:

The abstract operation NotifyWaiter takes arguments WL (a WaiterList Record) and waiterRecord (a Waiter Record) and returns unused.

@jmdyck
Copy link
Collaborator

jmdyck commented May 16, 2024

Looks like this happened in PR #3049.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants