Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.2.5 ResolveLocale 13.f.ii only considers zero or one 'type' subtag #59

Closed
vanwagonet opened this issue Dec 11, 2015 · 2 comments
Closed
Assignees
Labels

Comments

@vanwagonet
Copy link

ResolveLocale cannot accept some valid calendars in a u-ca- extension, because it only considers a key subtag followed by zero or one type subtags. RFC 6067 allows for "zero or more" type subtags to make the keyword.

In the current spec the following calendar identifiers are incorrectly matched:

  • ethiopic-amete-alem is an alias for ethioaa, but will be matched as ethiopic.
  • islamic-civil replaces the deprecated islamicc, but will be matched as islamic.
  • islamic-umalqura, islamic-tbla, and islamic-rgsa will each be matched as islamic.
@caridy caridy added the bug label Dec 11, 2015
@caridy caridy self-assigned this Dec 11, 2015
@caridy caridy closed this as completed in 7cb955c Feb 4, 2016
@vanwagonet
Copy link
Author

Thanks @caridy!

@jungshik
Copy link

Has a test been added for this? An indirect test would be possible with by checking the value of 'calendar' option. For instance, something like this can be used to test.

 var options = Intl.DateTimeFormat("ar-u-ca-islamic-civil").resolvedOptions();
 assertEquals(options.calendar, "islamic-civil");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants