Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_NativeError_.foo is allowed, but _NativeError_ [@@foo] is not #468

Closed
ljharb opened this issue Jul 7, 2022 · 3 comments · Fixed by #469
Closed

_NativeError_.foo is allowed, but _NativeError_ [@@foo] is not #468

ljharb opened this issue Jul 7, 2022 · 3 comments · Fixed by #469

Comments

@ljharb
Copy link
Member

ljharb commented Jul 7, 2022

In a proposal, I'm trying to add a Symbol property to NativeError constructors, but ecmarkup is complaining.
@bakkot
Copy link
Contributor

bakkot commented Jul 7, 2022

Yeah that check is probably a little too restrictive. I'll push up a fix, one sec.

@bakkot bakkot mentioned this issue Jul 7, 2022
Merged
@bakkot
Copy link
Contributor

bakkot commented Jul 8, 2022

Fixed in 13.0.1.

@ljharb
Copy link
Member Author

ljharb commented Jul 8, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tweak header name regex tc39/ecmarkup
2 participants
@ljharb @bakkot