Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing <emu-mods> #47

Closed
jmdyck opened this issue Sep 20, 2015 · 2 comments
Closed

missing <emu-mods> #47

jmdyck opened this issue Sep 20, 2015 · 2 comments
Labels

Comments

@jmdyck
Copy link
Contributor

jmdyck commented Sep 20, 2015

ecmarkdown converts

|Initializer_opt|

to

<emu-nt optional>Initializer</emu-nt>

which ecmarkup converts to

<emu-nt optional="">Initializer</emu-nt>

but this is missing

<emu-mods><emu-opt>opt</emu-opt></emu-mods>

Similarly,

|Pattern[U]|

converts to

<emu-nt params="U">Pattern</emu-nt>

which is missing

<emu-mods><emu-params>[U]</emu-params></emu-mods>
@bterlson
Copy link
Member

I was considering actually changing pipes to be non-terminal references, ie. |FunctionExpression| --> <emu-xref href="#prod-FunctionExpression"></emu-xref>. Maybe we could then get rid of the mods and leave it up to the emu-production styles to show or hide the them. Thoughts?

@bterlson
Copy link
Member

Fixed in 2.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants