Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationship with iterator-helpers #3

Closed
js-choi opened this issue Aug 31, 2021 · 2 comments
Closed

Relationship with iterator-helpers #3

js-choi opened this issue Aug 31, 2021 · 2 comments
Labels
question Further information is requested

Comments

@js-choi
Copy link
Collaborator

js-choi commented Aug 31, 2021 •
edited

The exciting iterator-helpers proposal has a similar toArray method that overlaps with this. (toArray already overlaps with Array.from too.) See #1.

My preference is to keep both toArray and Array.fromAsync (Array.from being a fait accompli). But we can explore this more before both proposals advance further. CC: @codehag
@bathos
Copy link

bathos commented Sep 1, 2021

I think both should exist, too. One reason is that they’re not quite equivalent: Array.fromAsync will work with any object implementing the async iterable contract regardless of whether it inherits from AsyncIteratorPrototype.

@js-choi js-choi mentioned this issue Sep 15, 2021
Closed
@js-choi
Copy link
Collaborator Author

js-choi commented Sep 15, 2021

See tc39/proposal-iterator-helpers#156.

@js-choi js-choi added the question Further information is requested label Sep 19, 2021
@js-choi js-choi closed this as completed Oct 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@js-choi @bathos