Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove built-in async function infrastructure from this proposal #36

Merged
merged 1 commit into from Nov 1, 2023

Conversation

michaelficarra
Copy link
Member

See tc39/proposal-iterator-helpers#245 and tc39/ecma262#2942. This will align our efforts and allow reviewers to focus on the actual content of this proposal.

@bakkot
Copy link
Contributor

bakkot commented Oct 24, 2022

Probably worth replacing this with a stub pointing to the PR? Or mentioning it in an editor's note, say.

Also, this proposal doesn't use the notion of a "built-in async function" - it's calling AsyncFunctionStart itself. Withhttps://github.com/tc39/ecma262/pull/2942 it could (and probably should) use that machinery, though.

@michaelficarra
Copy link
Member Author

I'll leave it up to the proposal authors to make further changes like that. Either in this PR or as a follow-up is fine by me.

@js-choi
Copy link
Collaborator

js-choi commented Nov 9, 2022

I will take a look at adding a stub soon. Apologies for the delay.

@ljharb
Copy link
Member

ljharb commented Nov 1, 2023

@js-choi ping, it's been almost a year

@js-choi
Copy link
Collaborator

js-choi commented Nov 1, 2023

@ljharb: Thanks for the ping. Apologies for dropping this task.

I am fine with this pull request’s removal of the AsyncFunction Objects section from the spec in favor of depending on tc39/ecma262#2942. That other pull request adds many things, but the important part for this proposal’s current spec is that it allows AsyncBlockStart to take an abstract closure as an argument.

I agree with @bakkot that adding a note referring to tc39/ecma262#2942 would be good, and I will add a note after merging this pull request now.

It’s also true that the Array.fromAsync spec does not currently use all of the new machinery that tc39/ecma262#2942 adds. It just uses its enhancement of AsyncFunctionStart. What other machinery should Array.fromAsync use? Would it be redefined as a “built-in async function object”? I also note that tc39/ecma262#2942 (comment) suggests that the final form of tc39/ecma262#2942 is still not completely settled.
Anyways, I’ll open a separate issue for that.

@js-choi js-choi merged commit f24fd1b into tc39:main Nov 1, 2023
@michaelficarra michaelficarra deleted the remove-built-in-async-functions branch November 1, 2023 22:12
js-choi added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants