Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolvedOptions ordering #30

Closed
Constellation opened this issue Aug 9, 2020 · 4 comments
Closed

resolvedOptions ordering #30

Constellation opened this issue Aug 9, 2020 · 4 comments
Labels
Milestone

Comments

@Constellation
Copy link

Looking into the spec of DurationFormat, and one thing I found is that the ordering of resolvedOptions is inconsistent to resolvedOptions in RelativeTimeFormat.
https://tc39.es/ecma402/#sec-intl.relativetimeformat.prototype.resolvedoptions
In RelativeTimeFormat,

  1. locale
  2. style
  3. numeric
  4. numberingSystem

In DurationFormat,

  1. locale
  2. numberingSystem
  3. style
  4. fields

While processing timings of numberingSystem and style are similar in DurationFormat and RelativeTimeFormat, their orderings are different. Currently I'm not sure which one should be appropriate, but I think we should make them consistent. Is there a policy about it?

@Constellation
Copy link
Author

/CC @rkirsling

@FrankYFTang
Copy link
Collaborator

This is NOT a editorial change but a normative change. While I am not not in particular think the consistency is important, the change of order will be a normative observable changes. I think you need to take out the "editorial' label.

@ryzokuken ryzokuken added this to the Stage 3 milestone Apr 5, 2021
@ryzokuken
Copy link
Member

ryzokuken commented Apr 5, 2021

@Constellation as Frank said, I don't care either way either. I will make this consistent once #32 is resolved.

@ryzokuken ryzokuken added the units label Apr 8, 2021
@ryzokuken
Copy link
Member

This is fixed in the latest update. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants