-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle {hours: 'numeric', minutes: 'long'}
?
#69
Comments
{hours: numeric, minutes: 'long'}
?{hours: 'numeric', minutes: 'long'}
?
Related: #64 (comment) Here is the rule I suggested there:
|
What about
Would we also need a rule for second->millisecond? eg. If "second" is "numeric", then "millisecond" must also be "numeric". |
Okay, how about if we just ensure that no alpha-type style (long, short, narrow) can be followed by a numeric-type style (numeric, 2-digit). Example pseudo-code algorithm:
|
I am assuming consensus on this as long as we don't have any objections: numeric type styles can only be followed by other numeric type styles. This is already a part of the spec PR at #68 |
This has been addressed by the PR at #68. Closing. |
What happens with weird styles like
{hours: 'numeric', minutes: 'long'}
? Should it throw? Does'long'
get "upgraded" to'2-digit'
like'numeric'
would have been? Does'numeric'
get upgraded to'long'
? Something else?(from #66 (comment))
The text was updated successfully, but these errors were encountered: