Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please fix the diff of SetNumberFormatDigitOptions #43

Closed
FrankYFTang opened this issue Jun 18, 2021 · 1 comment
Closed

please fix the diff of SetNumberFormatDigitOptions #43

FrankYFTang opened this issue Jun 18, 2021 · 1 comment

Comments

@FrankYFTang
Copy link
Contributor

Please fix the diff version of
https://tc39.es/proposal-intl-numberformat-v3/out/numberformat/diff.html#sec-initializenumberformat

The green/pink highlight looks missed a lot of changes from https://tc39.es/ecma402/ and is now very confusing to figure out which part is the change. Please compare with https://tc39.es/ecma402/ and highlight it correctly.
@sffc
Copy link
Collaborator

sffc commented Jun 18, 2021

The proposal's diff is based on upstream editorial PR tc39/ecma402#575, which is approved but not yet merged.

@sffc sffc closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sffc @FrankYFTang