Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Web compatibility issue with Yui2 #31

Open
evilpie opened this issue Oct 7, 2020 · 3 comments
Open

Web compatibility issue with Yui2 #31

evilpie opened this issue Oct 7, 2020 · 3 comments

Comments

@evilpie
Copy link

evilpie commented Oct 7, 2020

We just enabled String.prototype.item in Firefox Nightly and broke http://bugzilla.mozilla.org. We are going to backout this patch for that reason.

The problem seems to be in the obsolete Yui2 library: https://github.com/yui/yui2/blob/master/build/dom/dom.js#L789. It now assumes that strings are some kind of array/collections object.

@evilpie evilpie changed the title Web compatibilty issue with Yui2 Web compatibility issue with Yui2 Oct 7, 2020
@Constellation
Copy link

We are going to revert String#item as well.
https://bugs.webkit.org/show_bug.cgi?id=217449

@tabatkins
Copy link
Collaborator

Ah, well that makes the decision of whether to include String#item() or not easy - we'll just remove it.

@Jack-Works
Copy link
Member

🧐

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants